wchevreuil commented on a change in pull request #4052:
URL: https://github.com/apache/hbase/pull/4052#discussion_r831225465
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/replication/ReplicationPeerConfigUtil.java
##########
@@ -290,12 +290,14 @@ public static ReplicationPeerConfig
convert(ReplicationProtos.ReplicationPeer pe
peer.getTableCfsList().toArray(new
ReplicationProtos.TableCF[peer.getTableCfsCount()]));
if (tableCFsMap != null) {
builder.setTableCFsMap(tableCFsMap);
+ builder.setChainedFiltersOperation(peer.getChainOperator());
Review comment:
We could add some validation here, but none of the other already
existing fields are doing much validation either. An invalid value would fail
the addPeer operation later on ChainWALEntryFilter constructor, as the enum
"valueOf" call would raise an exception.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
