sunhelly commented on a change in pull request #4249:
URL: https://github.com/apache/hbase/pull/4249#discussion_r832830351
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java
##########
@@ -3727,14 +3734,24 @@ public ScanResponse scan(final RpcController
controller, final ScanRequest reque
if (context != null) {
context.setCallBack(rsh.shippedCallback);
} else {
- // When context != null, adding back the lease will be done in
callback set above.
- addScannerLeaseBack(lease);
+ // If context is null,we call rsh.shippedCallback directly to
release the
+ // internal resources in rsh.
+ runShippedCallback(rsh);
Review comment:
Oh, it also fixed the scanner leak problem caused by the null context
and partial results. LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
