pankaj72981 commented on a change in pull request #4248:
URL: https://github.com/apache/hbase/pull/4248#discussion_r833596976
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/MetricsHBaseServer.java
##########
@@ -129,8 +130,13 @@ public void exception(Throwable throwable) {
source.rpcThrottlingException();
} else if (throwable instanceof CallDroppedException) {
source.callDroppedException();
- } else if (LOG.isDebugEnabled()) {
- LOG.debug("Unknown exception type", throwable);
+ } else if (throwable instanceof RequestTooBigException) {
+ source.requestTooBigException();
+ } else {
+ source.otherExceptions();
+ if (LOG.isDebugEnabled()) {
+ LOG.debug("Unknown exception type", throwable);
+ }
Review comment:
Need to handle this in ThriftMetrics#exception() also.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
