bbeaudreault commented on a change in pull request #4253:
URL: https://github.com/apache/hbase/pull/4253#discussion_r834402620
##########
File path:
hbase-balancer/src/test/java/org/apache/hadoop/hbase/master/balancer/TestStochasticLoadBalancer.java
##########
@@ -519,6 +517,31 @@ public void testRegionLoadCost() {
assertEquals(2.5, result, 0.01);
}
+ @Test
+ public void testRegionLoadCostWhenDecrease() {
Review comment:
correct me if im wrong, but i believe this is testing the case where
region loads go `1, 2, 0, 4`. So it uses a 0 value in the 3rd slot. This works
to verify your change, but I wonder if it would be more comprehensive to test
`1, 2, 1, 4`. This was just be more indicative of a real reset where the value
starts at 0 but then gets incremented again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
