[
https://issues.apache.org/jira/browse/HBASE-26878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17512485#comment-17512485
]
Hudson commented on HBASE-26878:
--------------------------------
Results for branch branch-2
[build #498 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/498/]:
(x) *{color:red}-1 overall{color}*
----
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/498/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/498/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/498/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/498/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(x) {color:red}-1 client integration test{color}
--Failed when running client tests on top of Hadoop 2. [see log for
details|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/498//artifact/output-integration/hadoop-2.log].
(note that this means we didn't run on Hadoop 3)
> TableInputFormatBase should cache RegionSizeCalculator
> ------------------------------------------------------
>
> Key: HBASE-26878
> URL: https://issues.apache.org/jira/browse/HBASE-26878
> Project: HBase
> Issue Type: Improvement
> Reporter: Bryan Beaudreault
> Assignee: Bryan Beaudreault
> Priority: Minor
> Fix For: 2.5.0, 2.6.0, 3.0.0-alpha-3, 2.4.12
>
>
> TableInputFormatBase's getSplits() method instantiates a new
> RegionSizeCalculator every time. Instantiating a RegionSizeCalculator
> involves scanning for all regionlocations for a given table in meta. This can
> be costly for large tables, and we don't know how often a subclass will call
> getSplits().
> When initializeTable is called, we already cache the RegionLocator and Admin
> that are used for passing into the RegionSizeCalculator. We should similarly
> cache the RegionSizeCalculator itself at that same time to avoid unnecessary
> meta scans on repeat getSplits() calls.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
