joshelser commented on pull request #4223: URL: https://github.com/apache/hbase/pull/4223#issuecomment-1079236113
> what we need to do is restructure hbase-it so that the IntegrationTest jars are in src/main/java. > I don't mean to thrash things around. But I read through the changes here and the discussion around how to tell which classes in the test jars are magically detected for including this classpath and it all feels prohibitively brittle. I just want to come with some humility to ask that we don't look past fixing this immediate problem (to restore how things previously could work) to build an ideal solution. I would very much love to have our integration test code exposed via src/main/java so that maven transitive dependencies work, and JUnit wrappers so that they can be automatically invoked by a maven lifecycle phase. I also know that just because something previously could work in a certain way, doesn't mean that it was intentional to work that way (as Busbey pointed out -- this isn't 100% clear in the Book). I think we're all on the same page that this is a gap and it would be great to make meaningful changes to close those gaps. I just want to reinforce that we have a number of test suites at $dayjob which have now been broken for some time without any remediation. Wellington's current changes will help solve that problem and we can take our time to figure out how we want standalone tests to work in HBase with less urgency attached to it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
