[
https://issues.apache.org/jira/browse/HBASE-26617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17514625#comment-17514625
]
Duo Zhang commented on HBASE-26617:
-----------------------------------
This is what our current eclipse formatter does. I would say we never use the
style you proposed here in the past.
I've been using google java format, it will format the code like what you
proposed here, IIRC. But I've asked on dev list, we think it will cause a big
reformat on our code base which is not good.
But anyway, since we plan to do a big reformat now, maybe we could just tweak
the eclipse formatter file this time to do all the changes we want, before we
commit the big reformat patch?
> Use spotless to reduce the pain on fixing checkstyle issues
> -----------------------------------------------------------
>
> Key: HBASE-26617
> URL: https://issues.apache.org/jira/browse/HBASE-26617
> Project: HBase
> Issue Type: New Feature
> Components: build, community
> Reporter: Duo Zhang
> Assignee: Duo Zhang
> Priority: Major
> Fix For: 2.5.0, 3.0.0-alpha-3
>
>
> https://github.com/diffplug/spotless
> Spotless is a tool for reformatting code based on your configuration file, it
> supports the google java format, as well as a eclipse formatter file.
> I think we could use it to format our code, based on a configuration file in
> our repo, and all the developpers, no matter what IDE they use, they can just
> type a mvn spotless:apply before commiting a PR, then everything is fine.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
