[
https://issues.apache.org/jira/browse/HBASE-26617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17514659#comment-17514659
]
Duo Zhang edited comment on HBASE-26617 at 3/31/22, 12:10 AM:
--------------------------------------------------------------
{quote}
Another thought I had recently is we should maybe try to land the "big spotless
cleanup" PRs in master and the various branch-2[x] at roughly the same time.
Otherwise it's going to be a real pain to be cherry-picking commits when the
branches aren't in sync on formatting. But I could be over thinking?
{quote}
No. I agree with you that we'd better land the big PR at almost the same time,
especially, if a patch has already been committed to master, and we want to
backport them to other branches, then we should commit them before landing the
big reformat PR, otherwise it will be a big pain for the contributor or the
committers for cherry-picking...
was (Author: apache9):
{noformat}
Another thought I had recently is we should maybe try to land the "big spotless
cleanup" PRs in master and the various branch-2[x] at roughly the same time.
Otherwise it's going to be a real pain to be cherry-picking commits when the
branches aren't in sync on formatting. But I could be over thinking?
{noformat}
No. I agree with you that we'd better land the big PR at almost the same time,
especially, if a patch has already been committed to master, and we want to
backport them to other branches, then we should commit them before landing the
big reformat PR, otherwise it will be a big pain for the contributor or the
committers for cherry-picking...
> Use spotless to reduce the pain on fixing checkstyle issues
> -----------------------------------------------------------
>
> Key: HBASE-26617
> URL: https://issues.apache.org/jira/browse/HBASE-26617
> Project: HBase
> Issue Type: New Feature
> Components: build, community
> Reporter: Duo Zhang
> Assignee: Duo Zhang
> Priority: Major
> Fix For: 2.5.0, 3.0.0-alpha-3
>
>
> https://github.com/diffplug/spotless
> Spotless is a tool for reformatting code based on your configuration file, it
> supports the google java format, as well as a eclipse formatter file.
> I think we could use it to format our code, based on a configuration file in
> our repo, and all the developpers, no matter what IDE they use, they can just
> type a mvn spotless:apply before commiting a PR, then everything is fine.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
