Apache9 commented on a change in pull request #4136:
URL: https://github.com/apache/hbase/pull/4136#discussion_r839117090
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
##########
@@ -964,7 +969,8 @@ private void finishActiveMasterInitialization(MonitoredTask
status) throws IOExc
this.regionServerTracker.upgrade(
procsByType.getOrDefault(ServerCrashProcedure.class,
Collections.emptyList()).stream()
.map(p -> (ServerCrashProcedure) p).map(p ->
p.getServerName()).collect(Collectors.toSet()),
- walManager.getLiveServersFromWALDir(),
walManager.getSplittingServersFromWALDir());
+ Sets.union(rsListStorage.getAll(),
walManager.getLiveServersFromWALDir()),
Review comment:
This is for rolling upgrading, where we have nothing in the master local
region yet. I think we could remove the union in 4.0.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
