[
https://issues.apache.org/jira/browse/HBASE-26910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17515413#comment-17515413
]
Bryan Beaudreault commented on HBASE-26910:
-------------------------------------------
Proposal:
* add two new profiles in hbase-shaded: shaded-client (default) and
shaded-client-without-hadoop
* allow triggering between the 2 profiles using property
${shadedClientIncludeHadoop} (default true)
* shaded-client profile works as today:
** overwrite plugin config for execution id
aggregate-into-a-jar-with-relocated-third-parties, to remove hadoop exclusion
** add hbase-shaded-client-byo-hadoop module
* shaded-client-without-hadoop profile is simpler:
** don't overwrite aggregate-into-a-jar-with-relocated-third-parties, so
hadoop exclusion applies
** dont add hbase-shaded-client-byo-hadoop module
> Allow builders of hbase to specify hadoop mode for hbase-shaded-client
> ----------------------------------------------------------------------
>
> Key: HBASE-26910
> URL: https://issues.apache.org/jira/browse/HBASE-26910
> Project: HBase
> Issue Type: Improvement
> Reporter: Bryan Beaudreault
> Assignee: Bryan Beaudreault
> Priority: Major
>
> HBASE-20333 added a new shaded artifact, hbase-shaded-client-byo-hadoop. This
> is useful in environments where they already depend on hadoop so pulling in
> the hadoop classes from hbase-shaded-client would be extreme.
> I think the split that [~busbey] decided on there definitely made sense for
> the general case (with byo-hadoop being the specially named artifact). But
> some of us may work in environments where the default case is the byo-hadoop
> case. For those environments, it's a little confusing and verbose to have to
> refer to the hbase client as hbase-shaded-client-byo-hadoop everywhere.
> Using profiles I think we could provide an optional activation which allows
> someone building their own hbase to decide whether hbase-shaded-client should
> include hadoop or not. This way normal users using the artifacts published to
> maven central are unaffected, but super users building their own have some
> extra flexibility.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
