ndimiduk commented on a change in pull request #4223:
URL: https://github.com/apache/hbase/pull/4223#discussion_r839921114



##########
File path: hbase-assembly/pom.xml
##########
@@ -373,5 +373,14 @@
       <artifactId>opentelemetry-javaagent</artifactId>
       <classifier>all</classifier>
     </dependency>
+    <dependency>
+      <groupId>junit</groupId>
+      <artifactId>junit</artifactId>
+    </dependency>
+    <dependency>
+      <groupId>org.mockito</groupId>
+      <artifactId>mockito-core</artifactId>
+      <scope>compile</scope>

Review comment:
       This works? Great!
   
   Because `compile` is the default scope, someone later may be tempted to 
remove this distinction. Maybe add a comment to future do-gooders?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to