apurtell commented on a change in pull request #4136:
URL: https://github.com/apache/hbase/pull/4136#discussion_r840020262
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
##########
@@ -964,7 +969,8 @@ private void finishActiveMasterInitialization(MonitoredTask
status) throws IOExc
this.regionServerTracker.upgrade(
procsByType.getOrDefault(ServerCrashProcedure.class,
Collections.emptyList()).stream()
.map(p -> (ServerCrashProcedure) p).map(p ->
p.getServerName()).collect(Collectors.toSet()),
- walManager.getLiveServersFromWALDir(),
walManager.getSplittingServersFromWALDir());
+ Sets.union(rsListStorage.getAll(),
walManager.getLiveServersFromWALDir()),
Review comment:
There could be a migration step, and then taking the union is not
necessary. The concern here is tracking by two mechanisms can cause issues or
complicate troubleshooting if they get out of sync. It can be a follow up
change if deemed important at some future time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
