Apache9 commented on pull request #4312: URL: https://github.com/apache/hbase/pull/4312#issuecomment-1085494193
I downloaded the newest eclipse, imported our formatter file, did some modifications, and then exported it and replaced our current formatter file. What I changed are: 1. Change all the indent from default to 1, I saw a lot of checkstyle warnings which indicates that we indent more than expected. 2. Do not format file header. It is just the ASF license header, which do not need to be formatted. 3. As @ndimiduk point out, on method declarations, function calls and enum declarations we should wrap more, usually on every element if we need to wrap. So I changed the method declaration and function calls to 'wrap all elements, expect the first element if not necessary', and for function calls I also enabled 'Indent from the base expression's first line'. And for enum, I just use 'wrap all elements, every element on a new line'. 4. Remove 'Indent wrapped param/throws descriptions' as it seems useless. Let's see the style check result. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
