[ 
https://issues.apache.org/jira/browse/HBASE-6092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13293122#comment-13293122
 ] 

Andrew Purtell commented on HBASE-6092:
---------------------------------------

Let's look at flush as an example. If HRegionServer.flushRegion -> 
HRegion.flushcache -> coprocessor.preFlush, then AccessController.getActiveUser 
will find the user making the request in the RPC request context. Otherwise 
getActiveUser will substitute the system principal. Thus ADMIN permission must 
be granted to the system principal or flushes will fail. ADMIN permission is 
granted to the system principal by AccessController code when it initializes. 
As long as that doesn't change, this is ok.

Please update the comments in the tests you added. TestCompact does not verify 
that superuser and admin can create tables, etc. Otherwise the patch looks good.

                
> Authorize flush, split, compact operations in AccessController
> --------------------------------------------------------------
>
>                 Key: HBASE-6092
>                 URL: https://issues.apache.org/jira/browse/HBASE-6092
>             Project: HBase
>          Issue Type: Sub-task
>          Components: security
>    Affects Versions: 0.94.0, 0.96.0, 0.94.1
>            Reporter: Laxman
>            Assignee: Laxman
>              Labels: acl, security
>             Fix For: 0.96.0, 0.94.1
>
>         Attachments: HBASE-6092.patch
>
>
> Currently, flush, split and compaction are not checked for authorization in 
> AccessController. With the current implementation any unauthorized client can 
> trigger these operations on a table.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to