Apache9 commented on code in PR #4319:
URL: https://github.com/apache/hbase/pull/4319#discussion_r843354395
##########
dev-support/hbase-personality.sh:
##########
@@ -500,7 +500,7 @@ function shadedjars_rebuild
local -a maven_args=('clean' 'verify' '-fae' '--batch-mode'
'-pl' 'hbase-shaded/hbase-shaded-check-invariants' '-am'
- '-Dtest=NoUnitTests' '-DHBasePatchProcess' '-Prelease'
+ '-DskipTests' '-DHBasePatchProcess' '-Prelease'
Review Comment:
No, -DskipTests will executing the test-compile stage.
https://maven.apache.org/surefire/maven-surefire-plugin/examples/skipping-tests.html
> If you absolutely must, you can also use the maven.test.skip property to
skip compiling the tests. maven.test.skip is honored by Surefire, Failsafe and
the Compiler Plugin.
The '-DskipTests' is only honored by surefire plugin so it can not skip a
stage which is mainly controlled by other plugins...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
