clarax commented on code in PR #105:
URL:
https://github.com/apache/hbase-operator-tools/pull/105#discussion_r847552709
##########
hbase-hbck2/src/test/java/org/apache/hbase/TestHBCK2.java:
##########
@@ -121,26 +125,62 @@ public void testSetTableStateInMeta() throws IOException {
// Restore the state.
state = this.hbck2.setTableState(hbck, TABLE_NAME, state.getState());
assertTrue("Found=" + state.getState(), state.isDisabled());
+
+ // Test the new method with arg list
+ String[] args = new String[]{TABLE_NAME.getNameAsString(), "DISABLED"};
+ state = this.hbck2.setTableStateByArgs(hbck, args);
+ assertTrue("Found=" + state.getState(), state.isEnabled());
+ }
+ }
+
+ @Test
+ public void testSetTableStateWithInputFiles() throws IOException {
+ File testFile = new File(TEST_UTIL.getDataTestDir().toString(),
"inputForSetTableTest");
Review Comment:
My understanding is the test data dir is cleaned up between runs. I checked
in a test case long time ago which didn't cause any issue locally or on
Jenkins.
https://github.com/apache/hbase-operator-tools/blob/master/hbase-hbck2/src/test/java/org/apache/hbase/TestHBCK2.java#L153
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
