bbeaudreault commented on code in PR #4285:
URL: https://github.com/apache/hbase/pull/4285#discussion_r848527390
##########
hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncConnectionImpl.java:
##########
@@ -132,7 +133,8 @@ public AsyncConnectionImpl(Configuration conf,
ConnectionRegistry registry, Stri
this.connConf = new AsyncConnectionConfiguration(conf);
this.registry = registry;
if (conf.getBoolean(CLIENT_SIDE_METRICS_ENABLED_KEY, false)) {
- this.metrics = Optional.of(new MetricsConnection(this.toString(), () ->
null, () -> null));
+ String scope = conf.get(METRICS_SCOPE_KEY, clusterId + "-" + hashCode());
Review Comment:
Thanks! I'll fix that and also the one checkstyle warning before merging.
I'll plan to merge this as is to master, branch-2, and branch-2.5 I'll leave
the default alone for branch-2.4
##########
hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncConnectionImpl.java:
##########
@@ -132,7 +133,8 @@ public AsyncConnectionImpl(Configuration conf,
ConnectionRegistry registry, Stri
this.connConf = new AsyncConnectionConfiguration(conf);
this.registry = registry;
if (conf.getBoolean(CLIENT_SIDE_METRICS_ENABLED_KEY, false)) {
- this.metrics = Optional.of(new MetricsConnection(this.toString(), () ->
null, () -> null));
+ String scope = conf.get(METRICS_SCOPE_KEY, clusterId + "-" + hashCode());
Review Comment:
Thanks! I'll fix that and also the one checkstyle warning before merging.
I'll plan to merge this as is to master, branch-2, and branch-2.5. I'll leave
the default alone for branch-2.4
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
