Apache9 commented on code in PR #4338:
URL: https://github.com/apache/hbase/pull/4338#discussion_r848960055
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/Compactor.java:
##########
@@ -381,34 +376,50 @@ protected final List<Path> compact(final
CompactionRequestImpl request,
} else {
Closeables.close(scanner, true);
}
- if (!finished && writer != null) {
- abortWriter();
+ if (progress != null) {
+ this.progress.remove(progress);
+ }
+ if (writer != null) {
+ try {
+ if (!finished) {
+ // There was an error, so abort the writer.
+ abortWriter(writer);
+ return Collections.emptyList();
+ } else {
+ // Finished, commit the writer's results.
+ return commitWriter(writer, fd, request);
Review Comment:
The commitWriter here just means append metadata and close the writer, it
does not mean to record the files in SFT...
We still need to add something after the replaceStoreFile call to remove the
writer...
So maybe you are right, we need to use a Map instead of Set, the key can be
the CompactionRequestImpl?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
