apurtell commented on code in PR #4338:
URL: https://github.com/apache/hbase/pull/4338#discussion_r850876906
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/Compactor.java:
##########
@@ -344,6 +340,9 @@ protected final List<Path> compact(final
CompactionRequestImpl request,
boolean finished = false;
List<StoreFileScanner> scanners =
createFileScanners(request.getFiles(), smallestReadPoint, dropCache);
+ T writer = null;
+ CompactionProgress progress = new CompactionProgress(fd.maxKeyCount);
+ progressMap.put(request, progress);
Review Comment:
Right, the null handling was unfinished. Same for your other point as well.
But I think we will be going with @Apache9 's alternative.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
