Apache9 commented on code in PR #4305:
URL: https://github.com/apache/hbase/pull/4305#discussion_r851623093


##########
pom.xml:
##########
@@ -3032,7 +3033,8 @@
         <!-- TODO: replicate logic for windows support -->
         <argLine>--add-opens=java.base/jdk.internal.ref=ALL-UNNAMED 
${hbase-surefire.argLine}</argLine>
         <!-- We need a minimum HDFS version of 3.2.0 for HADOOP-12760 -->
-        <hadoop-three.version>3.2.0</hadoop-three.version>
+        <!-- We need a minimum HDFS version of 3.2.2 for HADOOP-16676 -->
+        <hadoop-three.version>3.2.3</hadoop-three.version>

Review Comment:
   Should be 3.2.2 instead of 3.2.3.



##########
dev-support/hbase-personality.sh:
##########
@@ -660,9 +660,9 @@ function hadoopcheck_rebuild
   else
     yetus_info "Setting Hadoop 3 versions to test based on 
branch-2.4+/master/feature branch rules"
     if [[ "${QUICK_HADOOPCHECK}" == "true" ]]; then
-      hbase_hadoop3_versions="3.1.2 3.2.2 3.3.1"
+      hbase_hadoop3_versions="3.1.4 3.2.3 3.3.1"

Review Comment:
   3.3.1 should be 3.3.2



##########
dev-support/hbase-personality.sh:
##########
@@ -660,9 +660,9 @@ function hadoopcheck_rebuild
   else
     yetus_info "Setting Hadoop 3 versions to test based on 
branch-2.4+/master/feature branch rules"
     if [[ "${QUICK_HADOOPCHECK}" == "true" ]]; then
-      hbase_hadoop3_versions="3.1.2 3.2.2 3.3.1"
+      hbase_hadoop3_versions="3.1.4 3.2.3 3.3.1"
     else
-      hbase_hadoop3_versions="3.1.1 3.1.2 3.2.0 3.2.1 3.2.2 3.3.0 3.3.1"
+      hbase_hadoop3_versions="3.1.4 3.2.2 3.2.3 3.3.0 3.3.1"

Review Comment:
   Should also add 3.3.2



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to