frostruan commented on code in PR #4335:
URL: https://github.com/apache/hbase/pull/4335#discussion_r851630491
##########
hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncTableRegionLocatorImpl.java:
##########
@@ -61,8 +62,23 @@ public CompletableFuture<List<HRegionLocation>>
getAllRegionLocations() {
return conn.registry.getMetaRegionLocations()
.thenApply(locs -> Arrays.asList(locs.getRegionLocations()));
}
- return ClientMetaTableAccessor
- .getTableHRegionLocations(conn.getTable(TableName.META_TABLE_NAME),
tableName);
+ CompletableFuture<List<HRegionLocation>> future = new
CompletableFuture<>();
+ addListener(ClientMetaTableAccessor.getTableHRegionLocations(conn
+ .getTable(TableName.META_TABLE_NAME), tableName), (locs, error) -> {
+ if (error != null) {
+ future.completeExceptionally(error);
+ return;
+ }
+ try {
+ locs.forEach(loc -> conn.getLocator()
+ .getNonMetaRegionLocator().addLocationToCache(loc));
+ } catch (Exception e) {
+ future.completeExceptionally(e);
+ } finally {
+ future.complete(locs);
Review Comment:
sorry, that's a stupid mistake..... Thanks for pointing out. I'll fix this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
