[
https://issues.apache.org/jira/browse/HBASE-26943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17525607#comment-17525607
]
Nick Dimiduk commented on HBASE-26943:
--------------------------------------
Heya [~heliangjun]. The visual improvement from your screenshots is a nice one,
thank you for picking this up. However, I have a couple concerns.
# The minimized bootstrap file comes directly from the upstream distribution,
which means that when we upgrade bootstrap in the future, we will lose your
change.
# The minimized file is minimized, including removal of whitespace, so as to
reduce its size over the wire. Adding formatting defeats the purpose of a
minimized resource.
# The title of the commit that was merged does not match the summary of this
JIRA. This is in breach of our community standards.
Please reopen this issue, reverting the change as committed, and address my
above concerns. I think a proper fix to this bug is to add your modified CSS to
some other css file later in the cascade. That may mean that you need to add a
new css file or edit the css definitions inline in the html, I'm not exactly
sure. When you do so, please ensure that the commit format matches our
community guidelines. Also, this is a nice visual fix, so please provide
back-port PRs for all of our active release lines: master, branch-2,
branch-2.5, and branch-2.4.
Thanks a lot for taking this one!
> HMaster page style display confusion
> ------------------------------------
>
> Key: HBASE-26943
> URL: https://issues.apache.org/jira/browse/HBASE-26943
> Project: HBase
> Issue Type: Improvement
> Components: master
> Affects Versions: 3.0.0-alpha-3
> Reporter: LiangJun He
> Assignee: LiangJun He
> Priority: Minor
> Fix For: 3.0.0-alpha-3
>
> Attachments: procedure_before.png, procedure_good.png,
> usertable_before.png, usertable_good.png
>
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
