ndimiduk commented on code in PR #4337:
URL: https://github.com/apache/hbase/pull/4337#discussion_r855116476
##########
pom.xml:
##########
@@ -3036,7 +3036,16 @@
<properties>
<maven.compiler.release>${releaseTarget}</maven.compiler.release>
<!-- TODO: replicate logic for windows support -->
- <argLine>--add-opens=java.base/jdk.internal.ref=ALL-UNNAMED
${hbase-surefire.argLine}</argLine>
+ <argLine>-Dio.netty.tryReflectionSetAccessible=true
+ --illegal-access=permit
+ --add-modules jdk.unsupported
+ --add-opens java.base/java.nio=ALL-UNNAMED
+ --add-opens java.base/sun.nio.ch=ALL-UNNAMED
+ --add-opens java.base/java.lang=ALL-UNNAMED
+ --add-opens=java.base/jdk.internal.ref=ALL-UNNAMED
Review Comment:
This one `add-opens` line uses an `=` to specify its argument, the rest
don't. Mine making them all uniform? Same thing in `bin/hbase`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
