ndimiduk commented on PR #4312: URL: https://github.com/apache/hbase/pull/4312#issuecomment-1108220373
> So what's your guys decision? Seems there is no perfect format, let's choose a 'not bad' one? > > Thanks. @ndimiduk @apurtell I'm not really satisfied by either -- the first is good for most scenarios but the last is better when there's lots of longer arguments. If I must choose one, I choose the first as it's likely the correct choice most of the time. At this point, I wonder if it's worth it for us as a community to maintain our own custom style guidelines. Perhaps we should adopt the [Google Java Style](https://google.github.io/styleguide/javaguide.html), use the [Google Java Format Tool](https://github.com/google/google-java-format), and move on. The former is well known and familiar to most devs by this point, and also is mostly identical to what we already do as a community. The latter is supported by all the major built tools via spotless plugins, as well as by both major IDEs. Thanks again, @Apache9, for spending time on this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
