Apache9 commented on code in PR #4381:
URL: https://github.com/apache/hbase/pull/4381#discussion_r862836283
##########
hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/ProcedureExecutor.java:
##########
@@ -1971,27 +2002,7 @@ public void run() {
continue;
}
this.activeProcedure = proc;
- int activeCount = activeExecutorCount.incrementAndGet();
- int runningCount = store.setRunningProcedureCount(activeCount);
- LOG.trace("Execute pid={} runningCount={}, activeCount={}",
proc.getProcId(),
- runningCount, activeCount);
- executionStartTime.set(EnvironmentEdgeManager.currentTime());
- IdLock.Entry lockEntry =
procExecutionLock.getLockEntry(proc.getProcId());
- try {
- executeProcedure(proc);
- } catch (AssertionError e) {
- LOG.info("ASSERT pid=" + proc.getProcId(), e);
- throw e;
- } finally {
- procExecutionLock.releaseLockEntry(lockEntry);
- activeCount = activeExecutorCount.decrementAndGet();
- runningCount = store.setRunningProcedureCount(activeCount);
- LOG.trace("Halt pid={} runningCount={}, activeCount={}",
proc.getProcId(),
- runningCount, activeCount);
- this.activeProcedure = null;
- lastUpdate = EnvironmentEdgeManager.currentTime();
- executionStartTime.set(Long.MAX_VALUE);
- }
+ lastUpdate = TraceUtil.trace(this::runProcedure, new
ProcedureSpanBuilder(proc));
Review Comment:
Something like 'Trace a one-shot execution of a procedure' seems more
accurate :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
