ndimiduk commented on code in PR #4393:
URL: https://github.com/apache/hbase/pull/4393#discussion_r862889009


##########
dev-support/hbase-personality.sh:
##########
@@ -869,6 +869,59 @@ function hbaseanti_patchfile
   return 0
 }
 
+######################################
+
+add_test_type spotless
+
+## @description  only run the test if java or pom changes.
+## @audience     private
+## @stability    evolving
+## @param        filename
+function spotless_filefilter
+{
+  local filename=$1
+
+  if [[ ${filename} =~ \.java$ ]] || [[ ${filename} =~ pom.xml$ ]]; then

Review Comment:
   Looking a the `spotless:apply` patch, it included reformatting of markdown, 
shell scripts, and xml as well. Unless we restrict the spotless scope in the 
pom configuration, better just let it run always.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to