bbeaudreault commented on code in PR #4400:
URL: https://github.com/apache/hbase/pull/4400#discussion_r865162848
##########
hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/TableRecordReaderImpl.java:
##########
@@ -66,12 +76,18 @@ public class TableRecordReaderImpl {
private boolean logScannerActivity = false;
private int logPerRowCount = 100;
+ private Duration renewLeasePeriod = null;
+
+ private Instant lastScannerRpcAt = null;
+
+ private ScheduledExecutorService renewTaskExecutor = null;
+
/**
* Restart from survivable exceptions by creating a new scanner.
* @param firstRow The first row to start at.
* @throws IOException When restarting fails.
*/
- public void restart(byte[] firstRow) throws IOException {
+ public synchronized void restart(byte[] firstRow) throws IOException {
Review Comment:
these 3 methods are synchronized because it probably would not be good if
renewLease were allowed to execute while creating the scanner or calling
`scanner.next`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
