[
https://issues.apache.org/jira/browse/HBASE-26977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17532649#comment-17532649
]
Hudson commented on HBASE-26977:
--------------------------------
Results for branch branch-2
[build #534 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/534/]:
(x) *{color:red}-1 overall{color}*
----
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/534/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/534/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/534/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/534/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(x) {color:red}-1 client integration test{color}
--Failed when running client tests on top of Hadoop 2. [see log for
details|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/534//artifact/output-integration/hadoop-2.log].
(note that this means we didn't run on Hadoop 3)
> HMaster's ShutdownHook does not take effect, if tablesOnMaster is false
> -----------------------------------------------------------------------
>
> Key: HBASE-26977
> URL: https://issues.apache.org/jira/browse/HBASE-26977
> Project: HBase
> Issue Type: Bug
> Components: master
> Affects Versions: 1.7.1, 2.4.9
> Reporter: LiangJun He
> Assignee: LiangJun He
> Priority: Major
> Attachments: image-2022-04-26-21-12-51-843.png,
> image-2022-04-26-21-18-24-884.png, image-2022-04-26-21-22-38-572.png
>
>
> Because we are going to upgrade the HBase kernel version, during the test, I
> found that the HMaster ShutdownHook of version 1.7.1 and 2.4.9 did not take
> effect if tablesOnMaster is false. After further confirmation, I found that
> all versions of HBase 1.x and 2.x have this problem.
> I analyzed the cause of the problem：
> Before HBase 3.x, HMaster registered ShutdownHook by calling the run() method
> of HRegionServer, but the run() method will be blocked on the
> waitForMasterActive() method of HMaster(before registering the shutdownhook)
> if tablesOnMaster is false. Eventually, the ShutdownHook of HMaster was not
> registered successfully.
> 1. The code path of HRegionServer's run() method：
> !image-2022-04-26-21-18-24-884.png!
>
> 2. The preRegistrationInitialization() method will be called first:
> !image-2022-04-26-21-12-51-843.png!
> 3. The HMaster's waitForMasterActive() method will be blocked if
> tablesOnMaster is false:
> !image-2022-04-26-21-22-38-572.png!
> Finally, because the default value of tablesOnMaster is false, the
> ShutdownHook of HMaster was not registered successfully.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
