[
https://issues.apache.org/jira/browse/HBASE-27019?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Kyle Purtell updated HBASE-27019:
----------------------------------------
Description:
TRACE level logging is expensive enough to warrant removal. They were useful
during development but now are just overhead.
{noformat}
1270039022 4.07% 127 jbyte_disjoint_arraycopy
{noformat}
e.g.
{noformat}
[ 0] jbyte_disjoint_arraycopy
[ 1] org.slf4j.impl.Reload4jLoggerAdapter.isTraceEnabled
[ 2] org.slf4j.impl.Reload4jLoggerAdapter.trace
[ 3]
org.apache.hadoop.hbase.io.compress.aircompressor.HadoopCompressor.setInput
[ 4] org.apache.hadoop.io.compress.BlockCompressorStream.write
[ 5] java.io.OutputStream.write
[ 6] com.salesforce.hbase.util.TestUtils.outputStreamTest
[ 7] com.salesforce.hbase.util.TestUtils.outputStreamTest
[ 8] com.salesforce.hbase.BenchmarkAircompressorLz4.test
[ 9]
com.salesforce.hbase.jmh_generated.BenchmarkAircompressorLz4_test_jmhTest.test_avgt_jmhStub
[10]
com.salesforce.hbase.jmh_generated.BenchmarkAircompressorLz4_test_jmhTest.test_AverageTime
{noformat}
Also we unnecessarily create new LZ4 compressor and decompressor instances in
the reset() methods.
was:
TRACE level logging is expensive enough to warrant removal. They were useful
during development but now are just overhead.
{noformat}
1270039022 4.07% 127 jbyte_disjoint_arraycopy
{noformat}
e.g.
{noformat}
[ 0] jbyte_disjoint_arraycopy
[ 1] org.slf4j.impl.Reload4jLoggerAdapter.isTraceEnabled
[ 2] org.slf4j.impl.Reload4jLoggerAdapter.trace
[ 3]
org.apache.hadoop.hbase.io.compress.aircompressor.HadoopCompressor.setInput
[ 4] org.apache.hadoop.io.compress.BlockCompressorStream.write
[ 5] java.io.OutputStream.write
[ 6] com.salesforce.hbase.util.TestUtils.outputStreamTest
[ 7] com.salesforce.hbase.util.TestUtils.outputStreamTest
[ 8] com.salesforce.hbase.BenchmarkAircompressorLz4.test
[ 9]
com.salesforce.hbase.jmh_generated.BenchmarkAircompressorLz4_test_jmhTest.test_avgt_jmhStub
[10]
com.salesforce.hbase.jmh_generated.BenchmarkAircompressorLz4_test_jmhTest.test_AverageTime
{noformat}
> Minor compression performance improvements
> ------------------------------------------
>
> Key: HBASE-27019
> URL: https://issues.apache.org/jira/browse/HBASE-27019
> Project: HBase
> Issue Type: Bug
> Reporter: Andrew Kyle Purtell
> Assignee: Andrew Kyle Purtell
> Priority: Trivial
> Fix For: 2.5.0, 3.0.0-alpha-3
>
>
> TRACE level logging is expensive enough to warrant removal. They were useful
> during development but now are just overhead.
> {noformat}
> 1270039022 4.07% 127 jbyte_disjoint_arraycopy
> {noformat}
> e.g.
> {noformat}
> [ 0] jbyte_disjoint_arraycopy
> [ 1] org.slf4j.impl.Reload4jLoggerAdapter.isTraceEnabled
> [ 2] org.slf4j.impl.Reload4jLoggerAdapter.trace
> [ 3]
> org.apache.hadoop.hbase.io.compress.aircompressor.HadoopCompressor.setInput
> [ 4] org.apache.hadoop.io.compress.BlockCompressorStream.write
> [ 5] java.io.OutputStream.write
> [ 6] com.salesforce.hbase.util.TestUtils.outputStreamTest
> [ 7] com.salesforce.hbase.util.TestUtils.outputStreamTest
> [ 8] com.salesforce.hbase.BenchmarkAircompressorLz4.test
> [ 9]
> com.salesforce.hbase.jmh_generated.BenchmarkAircompressorLz4_test_jmhTest.test_avgt_jmhStub
> [10]
> com.salesforce.hbase.jmh_generated.BenchmarkAircompressorLz4_test_jmhTest.test_AverageTime
> {noformat}
> Also we unnecessarily create new LZ4 compressor and decompressor instances in
> the reset() methods.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
