[jira] [Commented] (HBASE-26905) ReplicationPeerManager#checkPeerExists should throw ReplicationPeerNotFoundException if peer doesn't exists

[Andrew Kyle Purtell (Jira)]

    [ 
https://issues.apache.org/jira/browse/HBASE-26905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17534635#comment-17534635
 ] 

Andrew Kyle Purtell commented on HBASE-26905:
---------------------------------------------

Apologies for the long delayed response. This seems like a good idea 
[~shahrs87]. Did you or will you open a PR for it? This can go as far back as 
branch-2.5.

> ReplicationPeerManager#checkPeerExists should throw 
> ReplicationPeerNotFoundException if peer doesn't exists
> -----------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-26905
>                 URL: https://issues.apache.org/jira/browse/HBASE-26905
>             Project: HBase
>          Issue Type: Bug
>          Components: Replication
>            Reporter: Rushabh Shah
>            Priority: Major
>
> ReplicationPeerManager#checkPeerExists should throw 
> ReplicationPeerNotFoundException if peer doesn't exists. Currently it throws 
> generic DoNotRetryIOException.
> {code:java}
> private ReplicationPeerDescription checkPeerExists(String peerId) throws 
> DoNotRetryIOException {
>   ReplicationPeerDescription desc = peers.get(peerId);
>   if (desc == null) {
>     throw new DoNotRetryIOException("Replication peer " + peerId + " does not 
> exist");
>   }
>   return desc;
> } {code}



--
This message was sent by Atlassian Jira
(v8.20.7#820007)