tomscut opened a new pull request, #4423: URL: https://github.com/apache/hbase/pull/4423
By default Style/FrozenStringLiteralComment is open in rubocop. If we update a ruby file, rubocop prompts `Missing frozen string literal comment` (see [https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4416/2/artifact/yetus-general-check/output/diff-patch-rubocop.txt)](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4416/2/artifact/yetus-general-check/output/diff-patch-rubocop.txt). To address this warn, we need to add `# frozen_string_literal: true` to the top of the ruby file(see https://github.com/rubocop/rubocop/blob/master/config/default.yml#L3631), which will be added to the `Apache License` and will look strange. I don't think this `FrozenStringLiteralComment` check is very necessary. We can disable it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
