apurtell commented on code in PR #4439:
URL: https://github.com/apache/hbase/pull/4439#discussion_r875220379
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/CachedEntryQueue.java:
##########
@@ -22,6 +22,7 @@
import org.apache.hadoop.hbase.io.hfile.BlockCacheKey;
import org.apache.yetus.audience.InterfaceAudience;
+import org.apache.hbase.thirdparty.com.google.common.base.Preconditions;
Review Comment:
All the changes in this file seem extraneous?
Perhaps the findbugs exclusion can make a difference in the precommit
report, but overall these changes come from somewhere other than the thirdparty
changes?
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/MetaTableMetrics.java:
##########
@@ -203,41 +203,37 @@ private String opWithClientMeterName(Object op) {
return "";
}
MetaTableOps ops = opsNameMap.get(op.getClass());
- String opWithClientMeterName = "";
+ if (ops == null) {
Review Comment:
The changes in this file are all unrelated.
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/LruCachedBlockQueue.java:
##########
@@ -20,6 +20,7 @@
import org.apache.hadoop.hbase.io.HeapSize;
import org.apache.yetus.audience.InterfaceAudience;
+import org.apache.hbase.thirdparty.com.google.common.base.Preconditions;
Review Comment:
All the changes in this file seem extraneous?
Perhaps the whitespace change will avoid a spotless warning and findbugs
exclusion can make a difference in the precommit report, but overall these
changes come from somewhere other than the thirdparty changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
