[
https://issues.apache.org/jira/browse/HBASE-27026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17539867#comment-17539867
]
Tao Li edited comment on HBASE-27026 at 5/20/22 1:27 AM:
---------------------------------------------------------
Thanks [~janh] for your comments.
Yes, I tried in this PR [https://github.com/apache/hbase/pull/4416], but there
are still Rubocop warns. I'm also a little confused, so I started this
discussion.
!image-2022-05-20-09-14-36-355.png|width=411,height=337!
This is the document:
[https://github.com/rubocop/rubocop/blob/master/config/default.yml#L3637.]
!image-2022-05-20-09-25-05-608.png|width=493,height=322!
Could it be because of the Rubocop version? Or if there's something wrong with
the way I'm trying, please help point it out. Thank you very much. I'm not
familiar with Rubocop.
was (Author: tomscut):
Thanks [~janh] for your comments.
Yes, I tried in this PR [https://github.com/apache/hbase/pull/4416], but there
are still Rubocop warns. I'm also a little confused, so I started this
discussion.
!image-2022-05-20-09-14-36-355.png|width=411,height=337!
Could it be because of the Rubocop version? I'm not familiar with Rubocop.
> Disable Style/FrozenStringLiteralComment for ruby
> -------------------------------------------------
>
> Key: HBASE-27026
> URL: https://issues.apache.org/jira/browse/HBASE-27026
> Project: HBase
> Issue Type: Task
> Reporter: Tao Li
> Assignee: Tao Li
> Priority: Major
> Attachments: image-2022-05-20-09-14-36-355.png,
> image-2022-05-20-09-25-05-608.png
>
>
> By default Style/FrozenStringLiteralComment is enabled in rubocop. If we
> update a ruby file, rubocop prompts `Missing frozen string literal comment`
> (see
> [https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4416/2/artifact/yetus-general-check/output/diff-patch-rubocop.txt)|https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4416/2/artifact/yetus-general-check/output/diff-patch-rubocop.txt].
> To address this warn, we need to add `# frozen_string_literal: true` to the
> top of the ruby file(see
> https://github.com/rubocop/rubocop/blob/master/config/default.yml#L3637),
> which will be added to the top of the `Apache License` and will look strange.
> I don't think this `FrozenStringLiteralComment` check is very necessary. We
> can disable it.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
