ndimiduk commented on code in PR #4452:
URL: https://github.com/apache/hbase/pull/4452#discussion_r878110282
##########
bin/hbase:
##########
@@ -508,7 +508,7 @@ add_opentelemetry_agent() {
fi
agent_jar=$(tr ':' '\n' < "${f}" | grep opentelemetry-javaagent)
fi
- HBASE_OPTS="$HBASE_OPTS -javaagent:$agent_jar"
+ HBASE_OPTS="$HBASE_TRACE_OPTS -javaagent:$agent_jar"
Review Comment:
Good catch!
I don't think this correct either. Shouldn't we be adding `HBASE_TRACE_OPTS`
to `HBASE_OPTS`, not overriding `HBASE_OPTS` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
