pankaj72981 commented on code in PR #4431:
URL: https://github.com/apache/hbase/pull/4431#discussion_r879030905
##########
hbase-shell/src/main/ruby/hbase/admin.rb:
##########
@@ -1043,6 +1043,7 @@ def status(format, type)
else
puts "1 active master, #{cluster_metrics.getBackupMasterNames.size}
backup masters,
#{cluster_metrics.getLiveServerMetrics.size} servers,
+ #{@admin.listDecommissionedRegionServers.size} decommissioned,
Review Comment:
Cluster metrics approach is better than calling additional admin API
(includes a separate RPC).
Decommissioned and draining RegionServers are same,
https://github.com/apache/hbase/blob/1be2c83b3dc8306050f67828c9c2e361f19481c6/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java#L3821
Add decommissioned/draining RegionServer to ClusterMetrics class, currently
it is not there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
