joshelser commented on code in PR #4453:
URL: https://github.com/apache/hbase/pull/4453#discussion_r880996263
##########
hbase-common/src/main/java/org/apache/hadoop/hbase/io/encoding/HFileBlockDefaultDecodingContext.java:
##########
@@ -103,6 +103,11 @@ public void prepareDecoding(int onDiskSizeWithoutHeader,
int uncompressedSizeWit
compression.createDecompressionStream(dataInputStream,
decompressor, 0)) {
BlockIOUtils.readFullyWithHeapBuffer(is, blockBufferWithoutHeader,
uncompressedSizeWithoutHeader);
+ // The buffer has allocated space for checksum, but it's not
always filled. That might
Review Comment:
Yeah, I see this is getting allocated in HFileBlock#allocateBuffer. The
thing I'm left wondering if why `BlockIOUtils.readFullyWithHeapBuffer(..)` is
only _sometimes_ copying the checksum bytes after the uncompressed datablock. I
guess that is the outstanding question :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
