ss77892 commented on PR #4462: URL: https://github.com/apache/hbase/pull/4462#issuecomment-1138130360
> Nice catch @ss77892 ! I think this variable naming is misleading. Since you are already here, can you also rename this `regionDir` attribute to `walRegionDir` as to avoid such future mistakes? > > Also, I noticed this fix is also required in `master` branch, so in these cases, we typically open PR to master branch instead, then once it's merged, we cherry-pick it to the lower branches. Would you mind target this PR to `master` branch, instead? I've opened a PR to the master branch. Also I've renamed regionDir to regionWalDir. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
