Apache9 commented on code in PR #4457:
URL: https://github.com/apache/hbase/pull/4457#discussion_r884051841
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/master/region/MasterRegion.java:
##########
@@ -154,6 +154,10 @@ public RegionScanner getRegionScanner(Scan scan) throws
IOException {
return region.getScanner(scan);
}
+ public void rpcRequestFlush() {
Review Comment:
Just call it requestFlush?
##########
hbase-client/src/main/java/org/apache/hadoop/hbase/client/AdminOverAsyncAdmin.java:
##########
@@ -1078,4 +1078,9 @@ public List<LogEntry> getLogEntries(Set<ServerName>
serverNames, String logType,
ServerType serverType, int limit, Map<String, Object> filterParams) throws
IOException {
return get(admin.getLogEntries(serverNames, logType, serverType, limit,
filterParams));
}
+
+ @Override
+ public void flushMasterStore() throws IOException {
Review Comment:
Do you think we need to add a force flag here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
