2005hithlj commented on code in PR #4457:
URL: https://github.com/apache/hbase/pull/4457#discussion_r885737107
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/master/region/MasterRegion.java:
##########
@@ -155,7 +158,16 @@ public RegionScanner getRegionScanner(Scan scan) throws
IOException {
}
public FlushResult flush(boolean force) throws IOException {
- return region.flush(force);
+ flusherAndCompactor.resetChangesAfterLastFlush();
Review Comment:
At present, the flush method is only called by test cases, reset is not
called in this method, and there is no reset logic in the relevant test cases:
TestMasterRegionWALCleaner/TestMasterRegionOnTwoFileSystems and so on.
Can you help me make sure we don't need reset logic either?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
