ndimiduk commented on code in PR #4468:
URL: https://github.com/apache/hbase/pull/4468#discussion_r886014792
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/master/normalizer/RegionNormalizerWorkQueue.java:
##########
@@ -39,62 +39,22 @@
* {@link BlockingQueue}.</li>
* <li>Allows a producer to insert an item at the head of the queue, if
desired.</li>
* </ul>
- * Assumes low-frequency and low-parallelism concurrent access, so protects
state using a simplistic
- * synchronization strategy.
*/
@InterfaceAudience.Private
class RegionNormalizerWorkQueue<E> {
/** Underlying storage structure that gives us the Set behavior and FIFO
retrieval policy. */
private LinkedHashSet<E> delegate;
- // the locking structure used here follows the example found in
LinkedBlockingQueue. The
Review Comment:
It's super concerning that there's an issue here because, per this comment,
the implementation follows the locking implementation of `LinkedBlockingQueue`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
