Apache9 commented on code in PR #4459:
URL: https://github.com/apache/hbase/pull/4459#discussion_r887948020
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/MetaRegionLocationCache.java:
##########
@@ -91,8 +92,8 @@ public MetaRegionLocationCache(ZKWatcher zkWatcher) {
ThreadFactory threadFactory = new
ThreadFactoryBuilder().setDaemon(true).build();
RetryCounterFactory retryFactory = new
RetryCounterFactory(Integer.MAX_VALUE,
SLEEP_INTERVAL_MS_BETWEEN_RETRIES, SLEEP_INTERVAL_MS_MAX);
- threadFactory.newThread(() ->
loadMetaLocationsFromZk(retryFactory.create(), ZNodeOpType.INIT))
- .start();
+ threadFactory.newThread(Context.current()
Review Comment:
I suppose this is used to pass the span in the current scope to the thread,
so it will be recorded as parent span of later spans created in the thread. But
what if the current span is ended before the spans created in the thread end?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
