Apache9 commented on code in PR #4457:
URL: https://github.com/apache/hbase/pull/4457#discussion_r890684092
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java:
##########
@@ -457,6 +457,9 @@ public class HMaster extends
HBaseServerBase<MasterRpcServices> implements Maste
public static final String WARMUP_BEFORE_MOVE =
"hbase.master.warmup.before.move";
private static final boolean DEFAULT_WARMUP_BEFORE_MOVE = true;
+ // Only for testing
+ private boolean isLocalRegionFlushed = false;
Review Comment:
Is it possible to not adding a flag which is only used to verify test
result? I think you can add a CP method for the flushMasterRegion call, and use
attach a CP to verify that whether the master is called.
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/master/region/MasterRegion.java:
##########
@@ -155,7 +158,16 @@ public RegionScanner getRegionScanner(Scan scan) throws
IOException {
}
public FlushResult flush(boolean force) throws IOException {
- return region.flush(force);
+ flusherAndCompactor.resetChangesAfterLastFlush();
Review Comment:
We do not need to record the lastFlushTime here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
