[ 
https://issues.apache.org/jira/browse/HBASE-27084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17551112#comment-17551112
 ] 

Nick Dimiduk commented on HBASE-27084:
--------------------------------------

Can spotless be configured to only run on files checked into source control? 
After this change, {{mvn clean install}} gives me this annoying error,

{noformat}
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  4.685 s (Wall Clock)
[INFO] Finished at: 2022-06-07T15:59:26+02:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal 
com.diffplug.spotless:spotless-maven-plugin:2.22.5:check (default) on project 
hbase: The following files had format violations:
[ERROR]     .idea/workspace.xml
[ERROR]         @@ -908,4 +908,4 @@
[ERROR]          ······</configuration>
[ERROR]          ····</watches-manager>
[ERROR]          ··</component>
[ERROR]         -</project>
[ERROR]         +</project>
[ERROR] Run 'mvn spotless:apply' to fix these violations.
{noformat}

> Add spotless:check in mvn verify stage
> --------------------------------------
>
>                 Key: HBASE-27084
>                 URL: https://issues.apache.org/jira/browse/HBASE-27084
>             Project: HBase
>          Issue Type: Improvement
>          Components: build, pom
>            Reporter: Duo Zhang
>            Assignee: Duo Zhang
>            Priority: Major
>             Fix For: 2.5.0, 3.0.0-alpha-3, 2.4.13
>
>
> So mvn install will fail if we violate the format rules, which will make 
> developer pay more attention on fixing the format issue.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

Reply via email to