[ 
https://issues.apache.org/jira/browse/HBASE-27096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17551149#comment-17551149
 ] 

Duo Zhang commented on HBASE-27096:
-----------------------------------

It is added by this change

https://github.com/apache/hbase/commit/fb06ca5ba42824095ed30651720b21dee0b1624c

So, we have a .idea/checkstyle-idea.xml in our source control, and we have a 
/.idea/ line in our .gitignore at the same time?

> Exclude files which are not in source control as much as possible when 
> running spotless
> ---------------------------------------------------------------------------------------
>
>                 Key: HBASE-27096
>                 URL: https://issues.apache.org/jira/browse/HBASE-27096
>             Project: HBase
>          Issue Type: Improvement
>          Components: build, pom
>            Reporter: Duo Zhang
>            Assignee: Duo Zhang
>            Priority: Major
>
> In HBASE-27084, we added spotless:check to mvn verify stage, but the general 
> format section in spotless will include some files which are not in source 
> control, such as .idea/* or .settings/*, and then fail the 'mvn install'.
> Although usually it could be fixed by a spotless:apply call, but IDE may 
> regenerate the file and fail the build again.
> Let's add more exclude patterns to make it work better.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

Reply via email to