[
https://issues.apache.org/jira/browse/HBASE-27093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17551389#comment-17551389
]
Hudson commented on HBASE-27093:
--------------------------------
Results for branch branch-2
[build #561 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/561/]:
(x) *{color:red}-1 overall{color}*
----
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/561/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/561/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/561/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/561/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> AsyncNonMetaRegionLocator：put Complete CompletableFuture outside lock block
> ---------------------------------------------------------------------------
>
> Key: HBASE-27093
> URL: https://issues.apache.org/jira/browse/HBASE-27093
> Project: HBase
> Issue Type: Improvement
> Components: asyncclient, Client
> Affects Versions: 3.0.0-alpha-2, 2.4.12
> Environment: 2.4.12
> Reporter: zhiwang
> Assignee: zhiwang
> Priority: Major
> Labels: deadlock
> Fix For: 2.5.0, 3.0.0-alpha-3, 2.4.13
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
>
> {code:java}
> synchronized (tableCache) {
> tableCache.pendingRequests.remove(req);
> // fail the request itself, no matter whether it is a
> DoNotRetryIOException, as we have
> // already retried several times
> CompletableFuture<?> future = tableCache.allRequests.remove(req);
> if (future != null) {
> future.completeExceptionally(error);
> }
> tableCache.clearCompletedRequests(null);
> // Remove a complete locate request in a synchronized block, so the table
> cache must have
> // quota to send a candidate request.
> toSend = tableCache.getCandidate();
> toSend.ifPresent(r -> tableCache.send(r));
> }
> {code}
> Complete or completeExceptionally in a lock block may cause deadlock. We can
> put this action outside the lock block to avoid deadlock.
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
