[ 
https://issues.apache.org/jira/browse/HBASE-1524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kyle Purtell closed HBASE-1524.
--------------------------------------

> HBase[0.19.3]: TableInputFormatBase.TableRecordReader.restart() @line 110. 
> "startRow" should be changed to "firstRow"
> ---------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-1524
>                 URL: https://issues.apache.org/jira/browse/HBASE-1524
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.19.3
>            Reporter: Qiaoliang Xiang
>            Priority: Minor
>   Original Estimate: 1m
>  Remaining Estimate: 1m
>
> Version: 0.19.3
> Class org.apache.hadoop.hbase.mapred.TableInputFormatBase.TableRecordReader
> Method: restart()
> Line: 110
> Code: 
>      "this.scanner = this.htable.getScanner(trrInputColumns, startRow," 
> Suggestions:
>     Change startRow to firstRow.
> Reasons:
>     1. The restart() method tries to obtain a new Scanner given by the input 
> parameter firstRow under various conditions.
>          In both lines 114 and 119, firstRow are used for obtaining a 
> Scanner. However, at line 110, startRow is used, which
>          should be changed to firstRow.
>     2.  The init() method won't be affected since it calls restart(startRow) 
> at line 129.
>     3.  The next() method will be affected since it calls restart(lastRow) at 
> line 215.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

Reply via email to