[ 
https://issues.apache.org/jira/browse/HBASE-6229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13396629#comment-13396629
 ] 

Laxman commented on HBASE-6229:
-------------------------------

small nit

{code}
+  private boolean isNotEnabledorEnablingTable(final String tableName) {
+    return !zkTable.isEnablingTable(tableName) && 
!zkTable.isEnabledTable(tableName);
+  }
{code}

A separate method method may not be required for one liner. 
                
> AM.assign() should not set table state to ENABLED directly.
> -----------------------------------------------------------
>
>                 Key: HBASE-6229
>                 URL: https://issues.apache.org/jira/browse/HBASE-6229
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.92.2, 0.94.1
>            Reporter: rajeshbabu
>            Assignee: rajeshbabu
>             Fix For: 0.96.0, 0.94.1, 0.92.3
>
>         Attachments: HBASE-6229_94.patch, HBASE-6229_94_1.patch, 
> HBASE-6229_trunk.patch, HBASE-6229_trunk_1.patch
>
>
> In case of assign from EnableTableHandler table state is ENABLING. Any how 
> EnableTableHandler will set ENABLED after assigning all the the table 
> regions. If we try to set to ENABLED directly then client api may think 
> ENABLE table is completed. When we have a case like all the regions are added 
> directly into META and we call assignRegion then we need to make the table 
> ENABLED.  Hence in such case the table will not be in ENABLING or ENABLED 
> state.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to