[ 
https://issues.apache.org/jira/browse/HBASE-5630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13399570#comment-13399570
 ] 

Zhihong Ted Yu commented on HBASE-5630:
---------------------------------------

@Gregory:
How about deprecating the following in 0.94 ?
{code}
  public boolean balanceSwitch(final boolean b)
{code}
For 0.94 patch:
We can remove it in trunk.
{code}
+    if(synchronous == false) {
{code}
A space between if and (.
{code}
+    boolean oldBalancer = admin.setBalancerRunning(false,true);
{code}
A space between comma and 'true'.
                
> hbck should disable the balancer using synchronousBalanceSwitch.
> ----------------------------------------------------------------
>
>                 Key: HBASE-5630
>                 URL: https://issues.apache.org/jira/browse/HBASE-5630
>             Project: HBase
>          Issue Type: Improvement
>          Components: hbck
>    Affects Versions: 0.94.0, 0.96.0
>            Reporter: Jonathan Hsieh
>            Assignee: Gregory Chanan
>            Priority: Minor
>         Attachments: HBASE-5630-94.patch, HBASE-5630.patch
>
>
> hbck disable the balancer using admin.balanceSwith(bool) when it would be 
> preferable to use the newer synchronusBalanceSwitch method found in 0.94 and 
> trunk branches.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to