[ 
https://issues.apache.org/jira/browse/HBASE-6224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13399641#comment-13399641
 ] 

stack commented on HBASE-6224:
------------------------------

Patch looks good.  Its a pity StoreFile has to be made public but at list its 
limited private.  Fix this on commit:

{code}
+   * @param familyPaths family and path pairs to be bulk loaded
+   * @param hasLoaded whether load was successful or not
+   * @return
+   * @throws IOException
+   */
{code}

Add something for return since this is a class that will be implemented (Maybe 
say what the pair Paths are too?  StoreFiles?)

Else lgtm.  +1


                
> add Pre and Post coprocessor hooks for BulkLoad
> -----------------------------------------------
>
>                 Key: HBASE-6224
>                 URL: https://issues.apache.org/jira/browse/HBASE-6224
>             Project: HBase
>          Issue Type: Sub-task
>          Components: coprocessors
>    Affects Versions: 0.96.0, 0.94.1
>            Reporter: Francis Liu
>            Assignee: Francis Liu
>         Attachments: HBASE-6224-apurtell.patch, HBASE-6224.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to