[
https://issues.apache.org/jira/browse/HBASE-6200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13400264#comment-13400264
]
Hadoop QA commented on HBASE-6200:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12533237/6200-trunk-v2.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
-1 findbugs. The patch appears to introduce 11 new Findbugs (version
1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.regionserver.TestSplitTransactionOnCluster
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/2244//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/2244//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/2244//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/2244//console
This message is automatically generated.
> KeyComparator.compareWithoutRow can be wrong when families have the same
> prefix
> -------------------------------------------------------------------------------
>
> Key: HBASE-6200
> URL: https://issues.apache.org/jira/browse/HBASE-6200
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.6, 0.92.1, 0.94.0
> Reporter: Jean-Daniel Cryans
> Assignee: Jieshan Bean
> Priority: Blocker
> Fix For: 0.90.7, 0.92.2, 0.96.0, 0.94.1
>
> Attachments: 6200-trunk-v2.patch, HBASE-6200-90.patch,
> HBASE-6200-92.patch, HBASE-6200-94.patch, HBASE-6200-trunk-v2.patch,
> HBASE-6200-trunk.patch
>
>
> As reported by Desert Rose on IRC and on the ML, {{Result}} has a weird
> behavior when some families share the same prefix. He posted a link to his
> code to show how it fails, http://pastebin.com/7TBA1XGh
> Basically {{KeyComparator.compareWithoutRow}} doesn't differentiate families
> and qualifiers so "f:a" is said to be bigger than "f1:", which is false. Then
> what happens is that the KVs are returned in the right order from the RS but
> then doing {{Result.binarySearch}} it uses
> {{KeyComparator.compareWithoutRow}} which has a different sorting so the end
> result is undetermined.
> I added some debug and I can see that the data is returned in the right order
> but {{Arrays.binarySearch}} returned the wrong KV, which is then verified
> agains the passed family and qualifier which fails so null is returned.
> I don't know how frequent it is for users to have families with the same
> prefix, but those that do have that and that use those families at the same
> time will have big correctness issues. This is why I mark this as a blocker.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
